Code review for new library

Joe Nelson joe at begriffs.com
Fri Apr 30 02:28:31 UTC 2021


> This is a very shallow review, but I couldn't get the tests to run.
> 
>   make tests

Thanks for trying it out. Looks like I need better documentation. The
tests use assert() and the release build sets NDEBUG which disables
assertion checking. Try the dev variant instead:

make VARIANT=dev tests

./build/dev/test/run


(I'm curious if that'll compile for you, since the dev variant uses
clang specifically, while the release variant uses whatever your system
has assigned to CC.)


More information about the Friends mailing list